<div dir="ltr">Seems reasonable to me.<div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Oct 24, 2020 at 9:23 PM ThePhD via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">ThePhD added a comment.<br>
<br>
Minor addition for this change; if this does go through, llvm-specific macros in C-like languages should expose the chosen name. I submitted a patch and a feature request to MSVC and GCC for their own implementation-specific macros as well:<br>
<br>
- <a href="https://developercommunity.visualstudio.com/content/idea/1160821/-compiler-feature-macro-for-narrow-literal-foo-enc.html" rel="noreferrer" target="_blank">https://developercommunity.visualstudio.com/content/idea/1160821/-compiler-feature-macro-for-narrow-literal-foo-enc.html</a><br>
- <a href="https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555801.html" rel="noreferrer" target="_blank">https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555801.html</a><br>
<br>
It doesn't need to be synchronized with any other compiler's name or exposed feature: it just needs to exist. This allows folks interested in helping people write portable code that uses the execution character set preserve the invariants of their code by allowing them to inspect the name and act meaningfully for names they recognize.<br>
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D88741/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D88741/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D88741" rel="noreferrer" target="_blank">https://reviews.llvm.org/D88741</a><br>
<br>
</blockquote></div>