[PATCH] D85928: [libFuzzer] Added -print_full_coverage flag.
Max Moroz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 23 15:04:19 PDT 2020
Dor1s added inline comments.
================
Comment at: compiler-rt/lib/fuzzer/FuzzerTracePC.cpp:304
+ if (PrintAllCounters) {
+ if (UncoveredPCs.size() > 0) {
+ Printf("U");
----------------
mbarbella-chromium wrote:
> Dor1s wrote:
> > morehouse wrote:
> > > Do we need to exclude the U and C when the vectors are empty? It's slightly cleaner to exclude these if-statements.
> > I think it depends on the consuming side. Marty, what do you think?
> This should be easy enough to handle, though it may need a small update to the training script. I agree that it's cleaner to output them unconditionally, but I don't have strong feelings either way.
I think leaving this is-is would be slightly better, as at least from the user perspective it'd be explicit that this code was executed and the counters were empty.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85928/new/
https://reviews.llvm.org/D85928
More information about the llvm-commits
mailing list