[PATCH] D85928: [libFuzzer] Added -print_full_coverage flag.
Martin Barbella via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 23 12:49:10 PDT 2020
mbarbella-chromium added inline comments.
================
Comment at: compiler-rt/lib/fuzzer/FuzzerTracePC.cpp:304
+ if (PrintAllCounters) {
+ if (UncoveredPCs.size() > 0) {
+ Printf("U");
----------------
Dor1s wrote:
> morehouse wrote:
> > Do we need to exclude the U and C when the vectors are empty? It's slightly cleaner to exclude these if-statements.
> I think it depends on the consuming side. Marty, what do you think?
This should be easy enough to handle, though it may need a small update to the training script. I agree that it's cleaner to output them unconditionally, but I don't have strong feelings either way.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85928/new/
https://reviews.llvm.org/D85928
More information about the llvm-commits
mailing list