[PATCH] D74729: [FPEnv] Intrinsic for setting rounding mode

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 23 08:52:49 PDT 2020


RKSimon added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/ISDOpcodes.h:753
+  /// rounding mode, encoded in the same way as used in '``FLT_ROUNDS_``'.
+  SET_ROUNDING,
+
----------------
Sorry for the bikeshedding - but if SET_ROUNDING is supposed to match FLT_ROUNDS - shouldn't it have a more similar name?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74729/new/

https://reviews.llvm.org/D74729



More information about the llvm-commits mailing list