[PATCH] D89492: [compiler-rt] Enable building builtins using top-level CMake file

Fri Oct 23 07:43:34 PDT 2020

daltenty requested changes to this revision.
daltenty added inline comments.
This revision now requires changes to proceed.

================
Comment at: compiler-rt/cmake/builtin-config-ix.cmake:207
+  if (CRT_SUPPORTED_ARCH AND OS_NAME MATCHES "Linux")
+    set(COMPILER_RT_HAS_CRT TRUE)
+  else()
----------------
The problem we have here is that the scope for these variables has changed, builtin-config-ix.cmake is only included in the builtins CMakeList.tx, so when we go to check `COMPILER_RT_HAS_CRT` it's out of scope.

Perhaps it would be cleaner to split the CRT checks into it's own crt-config-ix.cmake that can be included at the appropriate scope?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89492/new/

https://reviews.llvm.org/D89492