[PATCH] D89492: [compiler-rt] Enable building builtins using top-level CMake file

[David Tenty via Phabricator via llvm-commits]

daltenty accepted this revision.
daltenty added a comment.
This revision is now accepted and ready to land.

LGTM, with slight adjustment. Though I will note that this requires a clean build because CMake will complain about the change in source directory in cache:

`CMake Error: The source “../compiler-rt/CMakeLists.txt" does not match the source ../compiler-rt/lib/builtins/CMakeLists.txt" used to generate cache.  Re-run cmake with a different source directory.`



================
Comment at: compiler-rt/CMakeLists.txt:126
+option(COMPILER_RT_BUILD_PROFILE "Build profile runtime" ON)
+mark_as_advanced(COMPILER_RT_BUILD_PROFILE)
+option(COMPILER_RT_BUILD_XRAY_NO_PREINIT "Build xray with no preinit patching" OFF)
----------------
fyi, this needs a slight adjustments because D87120 has landed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89492/new/

https://reviews.llvm.org/D89492