[PATCH] D89142: llvmbuildectomy

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

Do we really need a `LLVMBuild.cmake` for every component? I hoped it would be possible to derive that information from CMake's dependency graph (which would avoid them being out-of-sync). If it's not feasible to get that information from CMake, why not use add_llvm_library in the CMakeLists.txt to pass that information?



================
Comment at: llvm/cmake/modules/LLVM-Build.cmake:17
+#
+function(LLVMBuildComponent)
+
----------------
Even if already covered in `LLVMBuild.rst`, could you document which arguments are accepted here as well?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89142/new/

https://reviews.llvm.org/D89142