[PATCH] D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option
Keith Smiley via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 21 09:20:13 PDT 2020
keith added inline comments.
================
Comment at: llvm/test/tools/llvm-objcopy/MachO/install-name-tool-prepend-rpath.test:33
+
+# DUPLICATE-RPATH: rpath first_rpath would create a duplicate load command
+
----------------
jhenderson wrote:
> Reading this message, I think we should quote the rpath value, to make it clearer. Same might apply to similar messages, but doesn't need addressing in this patch.
I can address this in a follow up for all subcommands if that's ok
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89605/new/
https://reviews.llvm.org/D89605
More information about the llvm-commits
mailing list