[PATCH] D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 21 00:46:10 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one suggestion, which could be deferred to a follow-up if you want.



================
Comment at: llvm/test/tools/llvm-objcopy/MachO/install-name-tool-prepend-rpath.test:33
+
+# DUPLICATE-RPATH: rpath first_rpath would create a duplicate load command
+
----------------
Reading this message, I think we should quote the rpath value, to make it clearer. Same might apply to similar messages, but doesn't need addressing in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89605/new/

https://reviews.llvm.org/D89605



More information about the llvm-commits mailing list