[PATCH] D89881: [ARM] Alter t2DoLoopStart to define lr

[Sam Parker via Phabricator via llvm-commits]

samparker added a comment.

A heroic effort to change all those tests! Are you planning on also updating WLS and the test_set intrinsic too..?



================
Comment at: llvm/docs/LangRef.rst:15490
+
+      declare void @llvm.start.loop.iterations.i32(i32)
+      declare void @llvm.start.loop.iterations.i64(i64)
----------------
void -> i32, i64


================
Comment at: llvm/lib/CodeGen/HardwareLoops.cpp:328
 
-  InsertIterationSetup(LoopCountInit);
+  Value *LR = InsertIterationSetup(LoopCountInit);
 
----------------
Guess this should have a nice target agnostic name.


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:1079
 
     // Find an insertion point:
     // - Is there a (mov lr, Count) before Start? If so, and nothing else
----------------
I seem to remember that these mov lr searches only affect DoLoopStart, as the WhileLoopStart would usually/always be in the predecessor block, so you might be able to remove the two searches without having to change any other tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89881/new/

https://reviews.llvm.org/D89881