[PATCH] D89797: [WebAssembly] Implementation of (most) table instructions

[Paulo Matos via Phabricator via llvm-commits]

pmatos marked 5 inline comments as done.
pmatos added a comment.

Thanks for the review - I will submit a new revision.



================
Comment at: llvm/lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp:201
     case WebAssembly::OPERAND_FUNCTION32:
+    case WebAssembly::OPERAND_TABLE32:
     case WebAssembly::OPERAND_OFFSET32:
----------------
sbc100 wrote:
> This doesn't need the 32 suffix.. i think its more like OPERAND_GLOBAL.   I can't imagine us ever needing 2^^64 different tables... touch wood.
Ah - didn't Gates once said something similar regarding amount of required RAM? ;-)
Famous last words...


================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h:79
   OPERAND_BRLIST,
+  /// 32-bit unsigned table indices.
+  OPERAND_TABLE32,
----------------
sbc100 wrote:
> I think "table index" in ambiguous.   Maybe "table number"?
Agree.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89797/new/

https://reviews.llvm.org/D89797