[PATCH] D89797: [WebAssembly] Implementation of (most) table instructions

Tue Oct 20 22:57:42 PDT 2020

tlively added inline comments.

================
Comment at: llvm/test/MC/WebAssembly/tables.s:80
+# CHECK-NEXT:.Ltmp0:
+# CHECK-NEXR:	.size	copy_tables, .Ltmp0-copy_tables
+
----------------
sbc100 wrote:
> I think its common to put the expectations for each function inside or alongside the function itself.  
> 
> But I admit we are not very consistent in this directory.
> 
> What do you think about the style uses in `MC/WebAssembly/bulk-memory-encodings.s`or `simd-encodings.s`.
> 
> @tlively probably knows more about the right and wrong way to do this stuff.
Yeah, I would probably put the expected assembly output for each function just above that function and leave all the YAML at the bottom, but I agree that we aren't too consistent with this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89797/new/

https://reviews.llvm.org/D89797