[PATCH] D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs.

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 08:36:55 PDT 2020


hubert.reinterpretcast added a comment.

I have two concerns over the choice of the option form/name.

Firstly, there's an `-mabi=` option that is used to select for ABI extensions. The choice of using an `-mabi=` suboption for selecting between the extended vector ABI and the default vector ABI should be considered.
Secondly, the `vecnvol` name does not allude to its relation with the vector-extended ABI.

`-mabi=aixvecextabi` was suggested when I discussed this with someone who is familiar with GCC. The choice of `extabi` at the end is to match the spelling of the `__EXTABI__` macro.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89684/new/

https://reviews.llvm.org/D89684



More information about the llvm-commits mailing list