[PATCH] D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs.

[Xiangling Liao via Phabricator via llvm-commits]

Xiangling_L added inline comments.
Herald added a subscriber: dexonsmith.


================
Comment at: llvm/lib/CodeGen/CommandFlags.cpp:489
     Options.FloatABIType = getFloatABIForCalls();
+  Options.AIXExtendedAltivecABI = getAIXExtendedAltivecABI();
   Options.NoZerosInBSS = getDontPlaceZerosInBSS();
----------------
Should we also check `-vecnvol` option is used for AIX only somewhere?


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6927
+      !State.getMachineFunction().getTarget().Options.AIXExtendedAltivecABI)
+    report_fatal_error("the default Altivec AIX ABI is not yet supported.");
+
----------------
minor:
remove '.'


================
Comment at: llvm/test/CodeGen/PowerPC/aix-AppendingLinkage.ll:4
 
-; RUN: llc -verify-machineinstrs -mcpu=pwr4 -mtriple powerpc64-ibm-aix-xcoff < \
+; RUN: llc -verify-machineinstrs -mcpu=pwr4 -vecnvol -mtriple powerpc64-ibm-aix-xcoff < \
 ; RUN: %s | FileCheck %s
----------------
May I ask why would we want to add -vecnvol for those testcases? As I noticed, they don't need altivec feature enabled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89684/new/

https://reviews.llvm.org/D89684