[PATCH] D89317: [InstructionSimplify] icmp simplification

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 03:54:14 PDT 2020


SjoerdMeijer updated this revision to Diff 299325.
SjoerdMeijer added a comment.

Thanks for your help.

- this is using your function, the pattern matching, which indeed is much nicer,
- and I think all tests are there, positive and negative. For example, for the positive tests, I have added all the combos, the different data types, including a vector test, and for the negative tests, there are indeed tests with different predicate and the nsw is on the 'wrong' add, etc.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89317/new/

https://reviews.llvm.org/D89317

Files:
  llvm/lib/Analysis/InstructionSimplify.cpp
  llvm/test/Transforms/InstSimplify/compare.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89317.299325.patch
Type: text/x-patch
Size: 7029 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201020/9c5509db/attachment.bin>


More information about the llvm-commits mailing list