[PATCH] D89317: [InstructionSimplify] icmp simplification
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 19 12:35:12 PDT 2020
RKSimon added a reviewer: RKSimon.
RKSimon added inline comments.
================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:2879
+ ConstantInt *CC = dyn_cast<ConstantInt>(C);
+ ConstantInt *CD = dyn_cast<ConstantInt>(D);
+
----------------
Please would it be possible to use match + m_APInt instead? And add some uniform vector test coverage.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89317/new/
https://reviews.llvm.org/D89317
More information about the llvm-commits
mailing list