[PATCH] D89639: [lld-macho] Emit empty string as first entry of string table

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 19:03:18 PDT 2020

Previous message: [PATCH] D28088: MetadataLoader: simplify old type ref upgrade by removing a redundant set (NFC)
Next message: [PATCH] D89639: [lld-macho] Emit empty string as first entry of string table
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

smeenai added a comment.

Do we have any logic to emit an `n_strx` for an empty string? If so, that would need to be adjusted to emit 1 instead of 0. If not, LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89639/new/

https://reviews.llvm.org/D89639

Previous message: [PATCH] D28088: MetadataLoader: simplify old type ref upgrade by removing a redundant set (NFC)
Next message: [PATCH] D89639: [lld-macho] Emit empty string as first entry of string table
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list