[PATCH] D28088: MetadataLoader: simplify old type ref upgrade by removing a redundant set (NFC)

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith requested changes to this revision.
dexonsmith added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

I think we discussed this in person at the time, and my understanding of metadata-loading is now a bit hazy, but IIRC this was a performance optimization. IOW, I think removing this would be valid, but would be a major performance regression when linking in old bitcode files that have debug info in them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D28088/new/

https://reviews.llvm.org/D28088