[PATCH] D89162: [SVE] Lower fixed length VECREDUCE_SEQ_FADD operation

Mon Oct 19 09:13:49 PDT 2020

cameron.mcinally marked 5 inline comments as done.
cameron.mcinally added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:16147

+SDValue AArch64TargetLowering::LowerFixedLengthReductionAccToSVE(
+    unsigned Opcode, SDValue ScalarOp, SelectionDAG &DAG) const {
----------------
paulwalker-arm wrote:
> Given there's likely to be only one use of this I think calling this `LowerVECREDUCE_SEQ_FADD` is more inline with the naming of the other lowering functions.
I moved `LowerVECREDUCE_SEQ_FADD(...)` out from under `LowerVECREDUCE(...)`. Not sure if that helps or hurts @kmclaughlin, but I can change it if there's a problem.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89162/new/

https://reviews.llvm.org/D89162