[PATCH] D89519: [CGSCC] Add -abort-on-max-devirt-iterations-reached option

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/include/llvm/Analysis/CGSCCPassManager.h:645
 
       if (UR.InvalidatedSCCs.count(C))
         PI.runAfterPassInvalidated<LazyCallGraph::SCC>(Pass, PassPA);
----------------
rnk wrote:
> This is unrelated to your change, and I could be wrong here, but this seems like an awful lot of templated code that doesn't depend on `PassT` or `Pass`. How much of this can be sunk into a .cpp file, similar to the way you pushed down `maxDevitIterationsReached`?
Specifically for DevirtSCCRepeatedPass, I'm planning on removing a bunch of it soon :)
But point taken in general, I'll look around for potential savings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89519/new/

https://reviews.llvm.org/D89519