[PATCH] D89519: [CGSCC] Add -abort-on-max-devirt-iterations-reached option

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Code looks good to me as is.



================
Comment at: llvm/include/llvm/Analysis/CGSCCPassManager.h:645
 
       if (UR.InvalidatedSCCs.count(C))
         PI.runAfterPassInvalidated<LazyCallGraph::SCC>(Pass, PassPA);
----------------
This is unrelated to your change, and I could be wrong here, but this seems like an awful lot of templated code that doesn't depend on `PassT` or `Pass`. How much of this can be sunk into a .cpp file, similar to the way you pushed down `maxDevitIterationsReached`?


================
Comment at: llvm/include/llvm/Analysis/CGSCCPassManager.h:719
+        maxDevirtIterationsReached();
         LLVM_DEBUG(
             dbgs() << "Found another devirtualization after hitting the max "
----------------
The above thought was brought to you by considering if this LLVM_DEBUG goo should be pushed down into `maxDevirtIterationsReached`, but I decided it's probably not worth doing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89519/new/

https://reviews.llvm.org/D89519