[PATCH] D89384: [llvm-readobj/elf] - Change the behavior of handing DT_SONAME.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D89384#2333673 <https://reviews.llvm.org/D89384#2333673>, @MaskRay wrote:

>> Because of that both tools reports a warning for many our test cases.
>
> I am confused by this point. Is it about the behavior when .dynstr is absent?

Yes.

> .dynstr should always exist (st_size>=1).

It is about cases when we need to have the `.dynamic` section for whatever reason, but don't have the `DT_SONAME` tag.
Currently we don't recognize that it is absent and trying to read a string from the `.dynstr`.
In those tests we often don't need to have the `.dynstr`, so it doesn't exist.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89384/new/

https://reviews.llvm.org/D89384