[PATCH] D89384: [llvm-readobj/elf] - Change the behavior of handing DT_SONAME.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

> llvm-readelf doesn't need a string that is specified by DT_SONAME.
> llvm-readobj/elf always tries to read it, even when there is no DT_SONAME tag.

Agree. An absent DT_SONAME is like a value of 0.

> Because of that both tools reports a warning for many our test cases.

I am confused by this point. Is it about the behavior when .dynstr is absent? .dynstr should always exist (st_size>=1).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89384/new/

https://reviews.llvm.org/D89384