[PATCH] D89524: [NFC][SampleFDO] Move some common stuff from SampleProfileReaderExtBinary/SampleProfileWriterExtBinary to their parent classes.

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 15 19:51:10 PDT 2020


wmi created this revision.
wmi added reviewers: davidxl, wenlei, hoyFB.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
wmi requested review of this revision.

SampleProfileReaderExtBinary/SampleProfileWriterExtBinary specify the typical section layout currently used by SampleFDO. Currently a lot of section readers/writers stay in the two classes. However, as we expect to have more types of SampleFDO profiles, we hope those new types of profiles can share the common sections while configuring their own sections easily with minimal change. That is why I move some common stuff from SampleProfileReaderExtBinary/SampleProfileWriterExtBinary to SampleProfileReaderExtBinaryBase/SampleProfileWriterExtBinaryBase so new profiles class inheriting from the base class can reuse them.


Repository:
  rL LLVM

https://reviews.llvm.org/D89524

Files:
  llvm/include/llvm/ProfileData/SampleProfReader.h
  llvm/include/llvm/ProfileData/SampleProfWriter.h
  llvm/lib/ProfileData/SampleProfReader.cpp
  llvm/lib/ProfileData/SampleProfWriter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89524.298538.patch
Type: text/x-patch
Size: 16986 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201016/e215254a/attachment.bin>


More information about the llvm-commits mailing list