[PATCH] D87114: [CMake][ExecutionEngine] convert HAVE_EHTABLES_SUPPORT to a real config.h macro
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 15 19:10:50 PDT 2020
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/include/llvm/Config/config.h.cmake:62
+/* Define to 1 if we can register EH tables on this platform. */
+#cmakedefine01 HAVE_EHTABLE_SUPPORT
+
----------------
I think the name is not appropriate in the wider context. I suggest having separate config variables for each of the functions (like the one for `_Unwind_Backtrace`) and then using those to define `HAVE_EHTABLE_SUPPORT` where it is defined before this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87114/new/
https://reviews.llvm.org/D87114
More information about the llvm-commits
mailing list