[PATCH] D88353: [BasicAA] Integrate MaxObjSize for NoAlias

Wed Oct 14 12:27:33 PDT 2020

efriedma added a comment.

In D88353#2330829 <https://reviews.llvm.org/D88353#2330829>, @atmnpatel wrote:

> I think that phrase ("w/o maxobjsize deduction") could be a bit misleading, IINM, when @jdoerfert says w/o maxobjsize deduction he means without having the functionality built into the attributor to update the maximum object size estimate. So in the patch D87975 <https://reviews.llvm.org/D87975>, there's a crude over-approximation for the maxobjsize (getPointerMaxObjSize) and the numbers are for just using that over-approximation without including the changes in D87978 <https://reviews.llvm.org/D87978> that refine it, so we would still need the maxobjsize attribute first in order to do this.

As far as I can tell, without D87978 <https://reviews.llvm.org/D87978>, clang-generated IR won't contain any maxobjsize attributes.  So any changes to the generated code are unrelated to maxobjsize attribute.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88353/new/

https://reviews.llvm.org/D88353