[PATCH] D88353: [BasicAA] Integrate MaxObjSize for NoAlias

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D88353#2330829 <https://reviews.llvm.org/D88353#2330829>, @atmnpatel wrote:

> I think that phrase ("w/o maxobjsize deduction") could be a bit misleading, IINM, when @jdoerfert says w/o maxobjsize deduction he means without having the functionality built into the attributor to update the maximum object size estimate. So in the patch D87975 <https://reviews.llvm.org/D87975>, there's a crude over-approximation for the maxobjsize (getPointerMaxObjSize) and the numbers are for just using that over-approximation without including the changes in D87978 <https://reviews.llvm.org/D87978> that refine it, so we would still need the maxobjsize attribute first in order to do this.

I don't think we do. All the logic is there but since we never manifest `maxobjsize` to see this improvements we can commit this w/o the attribute part just fine. The attribute will come in when the Attributor deduces it, and when we annotate malloc and other library functions accordingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88353/new/

https://reviews.llvm.org/D88353