[PATCH] D84380: [lit] Support running tests on Windows without GnuWin32.

Wed Oct 14 11:38:50 PDT 2020

amccarth added a comment.

In D84380#2328034 <https://reviews.llvm.org/D84380#2328034>, @aganea wrote:

> In D84380#2315686 <https://reviews.llvm.org/D84380#2315686>, @aganea wrote:
>
>> Also, worth nothing that `C:\Program Files\Git\usr\bin` is not enough to run the lldb tests, which need `make` and maybe other things.
>> I'm not sure if that was part of your original goal, but since clang changes can affect lldb behavior, that means developers would still need some additionnal tools along Git for Windows.
>
> One more note: even after installing make with  `choco install make` and adding it to `%PATH%`, many lldb tests still fail because we call `sh F:\llvm-project\build\foo` and the backslashes are escaped by `sh`. We end up with `F:lvm-projectuildoo` something like this. We could maybe insert `cygpath` before the calls to `sh` to fix that in the lldb scripts.

I was under the impression that lit tests used a fake built-in shell on Windows.  Under what circumstances are Windows lit tests calling `sh.exe`?

I ask because I'm still trying to figure out why 899 LLDB tests started failing for me on Friday.  (Actually, it was 936 tests, but I fixed 37 of them with a fix to a line that was introduced almost a year ago.  I have not idea why the problems just started appearing on the 9th.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84380/new/

https://reviews.llvm.org/D84380