[PATCH] D84380: [lit] Support running tests on Windows without GnuWin32.

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 13 10:04:43 PDT 2020


aganea added a comment.

In D84380#2315686 <https://reviews.llvm.org/D84380#2315686>, @aganea wrote:

> Also, worth nothing that `C:\Program Files\Git\usr\bin` is not enough to run the lldb tests, which need `make` and maybe other things.
> I'm not sure if that was part of your original goal, but since clang changes can affect lldb behavior, that means developers would still need some additionnal tools along Git for Windows.

One more note: even after installing make with  `choco install make` and adding it to `%PATH%`, many lldb tests still fail because we call `sh F:\llvm-project\build\foo` and the backslashes are escaped by `sh`. We end up with `F:lvm-projectuildoo` something like this. We could maybe insert `cygpath` before the calls to `sh` to fix that in the lldb scripts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84380/new/

https://reviews.llvm.org/D84380



More information about the llvm-commits mailing list