[PATCH] D82745: [ThinLto] Fix Ifunc symbol usage

[Vladislav Khmelevsky via Phabricator via llvm-commits]

yota9 added a comment.

Dear @tejohnson!
Sorry for the late answer, the task is not prioritized and I don't have much time to finish it :)
Still  I've added GlobalIndirectSummary class as you've requested and decided not to import ifuncs for now, since it should be handled another way then aliases (still AFAIU there is not so much sense in it, maybe only if the resolver unconditionally  returns only one function, but in other way unlike aliases ifunc is a relocation that should be processed at runtime).
It seems to be ifunc_import test is not needed, but still added it, maybe it will be useful if somebody will import ifuncs in the future..
Thank you so much for your patch review!



================
Comment at: llvm/lib/IR/Verifier.cpp:383
 
+    for (const GlobalIFunc &I : M.ifuncs())
+      visitGlobalIfunc(I);
----------------
tejohnson wrote:
> The changes in this file seem unrelated to ThinLTO. Can you split into another patch (with test)?
I see, no problems :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82745/new/

https://reviews.llvm.org/D82745