[PATCH] D89094: [objdump][macho] Check arch before formating reloc name as arm64 addend

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 22:19:28 PDT 2020


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

(MachoDump.cpp needs more love. It is overly complicated and greatly under tested/maintenance)



================
Comment at: llvm/tools/llvm-objdump/MachODump.cpp:457
+  if (O->getAnyRelocationType(RE) == MachO::ARM64_RELOC_ADDEND &&
+      (O->getArch() == Triple::aarch64 || O->getArch() == Triple::aarch64_be)) {
     Fmt << format("0x%0" PRIx64, Val);
----------------
`getArch().isAArch64()`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89094/new/

https://reviews.llvm.org/D89094



More information about the llvm-commits mailing list