[PATCH] D89094: [objdump][macho] Check arch before formating reloc name as arm64 addend

Peng Guo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 22:15:14 PDT 2020


pguo added a comment.

For the macho, there already has a test case which is `llvm/test/tools/llvm-objdump/MachO/AArch64/macho-reloc-addend.test`.  And to test this change, we need a macho with different architecture which using a different relocation type with enum value 10 (which is the enum value of MachO::ARM64_RELOC_ADDEND). The issue is for current llvm, only PPC defined a different relocation type with value 10, but the macho backend for PPC has been deleted from llvm. So currently we cannot make such a test in upstream llvm.
The logic here is simple and clear.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89094/new/

https://reviews.llvm.org/D89094



More information about the llvm-commits mailing list