[PATCH] D89166: Sink: Handle instruction sink when a user is dead

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 15:57:17 PDT 2020


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

'unreachable' may be more appropriate than 'dead'.

Please mention that this fixes PR47415 ( https://bugs.llvm.org/show_bug.cgi?id=47415)

> In addition, if findNearestCommonDominator fails somehow, we bail out instruction sinking.

This sentence should be deleted.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89166/new/

https://reviews.llvm.org/D89166



More information about the llvm-commits mailing list