[PATCH] D89166: Sink: Handle instruction sink when a user is dead

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 15:50:33 PDT 2020


cfang marked an inline comment as done.
cfang added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/Sink.cpp:150
+      // findNearestCommonDominator may fail for some reasons.
+      if (!SuccToSinkTo)
+        return false;
----------------
MaskRay wrote:
> After `D88758`, the return value cannot be nullptr.
Done. Remove the checking.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89166/new/

https://reviews.llvm.org/D89166



More information about the llvm-commits mailing list