[PATCH] D89076: AMDGPU: Update AMDHSA code object version handling

[Tony Tye via Phabricator via llvm-commits]

t-tye added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:2464-2467
+def mcode_object_v3_legacy : Flag<["-"], "mcode-object-v3">, Group<m_Group>,
+  HelpText<"Legacy option to specify code object v3 (AMDGPU only)">;
+def mno_code_object_v3_legacy : Flag<["-"], "mno-code-object-v3">, Group<m_Group>,
+  HelpText<"Legacy option to specify code object v2 (AMDGPU only)">;
----------------
MaskRay wrote:
> Does this still need `m_amdgpu_Features_Group`?
Would it be worth stating that the replacement option is "-mllvm --amdhsa-code-object-version=2" and "-mllvm --amdhsa-code-object-version=3" respectively?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89076/new/

https://reviews.llvm.org/D89076