[PATCH] D89076: AMDGPU: Update AMDHSA code object version handling

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 8 19:39:04 PDT 2020


MaskRay added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:2464
 
-def mcode_object_v3 : Flag<["-"], "mcode-object-v3">, Group<m_amdgpu_Features_Group>,
-  HelpText<"Enable code object v3 (AMDGPU only)">;
-def mno_code_object_v3 : Flag<["-"], "mno-code-object-v3">, Group<m_amdgpu_Features_Group>,
-  HelpText<"Disable code object v3 (AMDGPU only)">;
+def mcode_object_v3_legacy : Flag<["-"], "mcode-object-v3">, Group<m_Group>,
+  HelpText<"Legacy option to specify code object v3 (AMDGPU only)">;
----------------
Does this still need `m_amdgpu_Features_Group`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89076/new/

https://reviews.llvm.org/D89076



More information about the llvm-commits mailing list