[PATCH] D88787: [llvm][mlir] Promote the experimental reduction intrinsics to be first class intrinsics.

Wed Oct 7 11:23:12 PDT 2020

aemerson added a comment.

In D88787#2317464 <https://reviews.llvm.org/D88787#2317464>, @NathanielMcVicar wrote:

> I think there may be a small remaining issue on the llvmir-intrinsics.mlir test on Windows, as seen here: http://lab.llvm.org:8011/#/builders/82/builds/40/steps/7/logs/stdio
>
>   $ ":" "RUN: at line 1"
>   $ "e:\build_slave\mlir-x64-windows-ninja\build\bin\mlir-translate.exe" "-mlir-to-llvmir" "E:\build_slave\mlir-x64-windows-ninja\llvm-project\mlir\test\Target\llvmir-intrinsics.mlir"
>   # command stderr:
>   Expected an argument of Vector Type
>   UNREACHABLE executed at E:\build_slave\mlir-x64-windows-ninja\llvm-project\llvm\lib\IR\Function.cpp:1167!

Yep, I've just pushed c1247f0e74bff00ab9a896a8132318916f3e84a7 <https://reviews.llvm.org/rGc1247f0e74bff00ab9a896a8132318916f3e84a7> to hopefully fix that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88787/new/

https://reviews.llvm.org/D88787