[PATCH] D10885: Initialize raw_ostream buffer mode using an enum instead of a boolean

[Duncan P. N. Exon Smith via llvm-commits]

Hmm, that rings a bell. I don't feel strongly either way.

> On Oct 6, 2020, at 18:44, Mehdi AMINI <joker.eph at gmail.com> wrote:
> 
> I can try to bring this back if there is interest in this.
> 
> As far as I remember I got feedback that this wasn't worth it compared to a bool and a comment at call sites (was it Justin's feedback maybe?)
> Basically:
> 
>   raw_fd_ostream OF(TestFD, true, /*unbuffered=*/true);
> 
> vs
> 
>   raw_fd_ostream OF(TestFD, true, StreamMode::Unbuffered);
> 
> 
> On Tue, Oct 6, 2020 at 3:40 PM Duncan P. N. Exon Smith via Phabricator <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
> dexonsmith resigned from this revision.
> dexonsmith added a comment.
> Herald added a subscriber: jfb.
> 
> Resigning to take this off my queue since this is 5+ years old, but this looks like a nice change that I'd be happy to review. Add me back if you want me to take a look at this or a rebased patch.
> 
> 
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D10885/new/ <https://reviews.llvm.org/D10885/new/>
> 
> https://reviews.llvm.org/D10885 <https://reviews.llvm.org/D10885>
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201006/33c571e3/attachment.html>