<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hmm, that rings a bell. I don't feel strongly either way.<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Oct 6, 2020, at 18:44, Mehdi AMINI <<a href="mailto:joker.eph@gmail.com" class="">joker.eph@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class="">I can try to bring this back if there is interest in this.<div class=""><br class=""></div><div class="">As far as I remember I got feedback that this wasn't worth it compared to a bool and a comment at call sites (was it Justin's feedback maybe?)</div><div class="">Basically:</div><div class=""><br class=""></div><div class=""><div class=""> raw_fd_ostream OF(TestFD, true, /*unbuffered=*/true);</div></div><div class=""><br class=""></div><div class="">vs</div><div class=""><br class=""></div><div class=""><div class=""> raw_fd_ostream OF(TestFD, true, StreamMode::Unbuffered);</div></div><div class=""><br class=""></div></div></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 6, 2020 at 3:40 PM Duncan P. N. Exon Smith via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank" class="">reviews@reviews.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">dexonsmith resigned from this revision.<br class="">
dexonsmith added a comment.<br class="">
Herald added a subscriber: jfb.<br class="">
<br class="">
Resigning to take this off my queue since this is 5+ years old, but this looks like a nice change that I'd be happy to review. Add me back if you want me to take a look at this or a rebased patch.<br class="">
<br class="">
<br class="">
CHANGES SINCE LAST ACTION<br class="">
<a href="https://reviews.llvm.org/D10885/new/" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D10885/new/</a><br class="">
<br class="">
<a href="https://reviews.llvm.org/D10885" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D10885</a><br class="">
<br class="">
</blockquote></div>
</div></blockquote></div><br class=""></body></html>