[PATCH] D84380: [lit] Support running tests on Windows without GnuWin32.

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

In D84380#2315093 <https://reviews.llvm.org/D84380#2315093>, @amccarth wrote:

> Sometimes what you want or need in your shell is different than what the build needs.

Adrian, are there use cases where the steps in my previous post (https://reviews.llvm.org/D84380#2314959) wouldn't work without this patch, or where auto-detection is preferable? If Git isn't in `%PATH%`, one could add `-DLLVM_LIT_TOOLS_DIR`, no? I reckon that's an extra option to provide (as opposed to auto-detection), but that leaves latitude to users?

I think one thing that was missing here is visiblity. If we display the auto-detected path, and tell users by the same occasion that it can be changed through some option, maybe that would be better. One other issue is maybe that auto-detection comes late in the process - when running the tests. Shall we do that in cmake instead? Also, we're mixing a runtime setup (%PATH% or registry detection) and a static setup (LLVM_LIT_TOOLS_DIR).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84380/new/

https://reviews.llvm.org/D84380