[PATCH] D84380: [lit] Support running tests on Windows without GnuWin32.

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 12:59:22 PDT 2020


amccarth added a comment.

In D84380#2314645 <https://reviews.llvm.org/D84380#2314645>, @hans wrote:

> It seems confusing to me to automagically use tools that are not on PATH (or passed in explicitly as cmake flags or similar).

It's confusing me why builds should be so sensitive to the user's environment.  Sometimes what you want or need in your shell is different than what the build needs.  We essentially have an high dimensional matrix of build configurations, which is completely unsupportable.  This change was a step in the right direction in that it lopped off one of the countless dimensions where things could go wrong by making it easy to use current, supported tools.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84380/new/

https://reviews.llvm.org/D84380



More information about the llvm-commits mailing list