[PATCH] D88706: [OpenMP][MLIR] WIP : Fix for nested parallel region

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 10:41:11 PDT 2020


kiranchandramohan added a comment.

Thanks @fghanim for the detailed response. Very helpful.

As @SouraVX is suggesting, when FIR is created I believe there are entry blocks where allocas are placed. These would be converted to llvm dialect allocas in MLIR. Since blocks are translated in topological order, the entry block would have been processed (converted to LLVM IR allocas) when we reach an OpenMP operation. So I believe a location in the entry block (last alloca, or first alloca) can be passed as the outer allocaIP. We can also either structure the region inside the OpenMP operation to have an entry block and pass it to the OpenMP IRBuilder as the inner allocaIP.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88706/new/

https://reviews.llvm.org/D88706



More information about the llvm-commits mailing list