[PATCH] D88706: [OpenMP][MLIR] WIP : Fix for nested parallel region

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX added a subscriber: schweitz.
SouraVX added a comment.

In D88706#2309408 <https://reviews.llvm.org/D88706#2309408>, @fghanim wrote:

> 



> Here is a question regarding allocas in the llvm dialect; by the time they are translated to llvm ir proper, are they already located in the entry block in the dialect itself, or are they located in different places but you have something like an `AllocaIP` where you move allocas to entry block during the translation to proper llvm IR?
> What is FIR planning to do about their stack allocations? if they are not guaranteeing it's in the entry BB then that's an issue.

AFAIK both of these cases we end up having `alloca` in the entry block.
@schweitz can confirm this WRT `FIR`.

Overall I think this might be a phase ordering problem, i.e we are outlining late(every thing is already at `LLVMIR Dialect` level) we've lost the `insertionPoint` abstraction.
`clang` handle all this differently.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88706/new/

https://reviews.llvm.org/D88706