[PATCH] D86203: [GlobalISel][TableGen] Add handling of unannotated dst pattern ops

Gabriel Hjort Ã…kerlund via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 2 02:40:32 PDT 2020


ehjogab added a comment.

In D86203#2303410 <https://reviews.llvm.org/D86203#2303410>, @arsenm wrote:

> Does not annotating the output really buy you much? I think inconsistent behaviors in tablegen is a bigger obstacle to understanding patterns

It buys me the effort of having to go through all patterns in our target and add these manually. There are over 1300 patterns, meaning it will be tedious and time-consuming having to go through each and every one, look up the register classes of all arguments to the instruction, and annotate these. But since everyone else have had to do this for other targets, I suppose I will be forced to do the same.

Unless someone else is willing to argue towards having this patch accepted, I see no point in spending more time on this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86203/new/

https://reviews.llvm.org/D86203



More information about the llvm-commits mailing list