[PATCH] D86203: [GlobalISel][TableGen] Add handling of unannotated dst pattern ops

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Does not annotating the output really buy you much? I think inconsistent behaviors in tablegen is a bigger obstacle to understanding patterns



================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:4161-4162
+getNumRegClassesInDag(const DagInit *Dag) {
+  std::string Op = Dag->getOperator()->getAsString();
+  if (Op.compare("add") == 0) {
+    unsigned Count = 0;
----------------
I think trying to parse this manually is problematic


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86203/new/

https://reviews.llvm.org/D86203