[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

Thu Oct 1 11:05:38 PDT 2020

sfertile added inline comments.

================
Comment at: llvm/test/CodeGen/PowerPC/aix-csr-vector.ll:19
+entry:
+  call void asm sideeffect "", "~{v13},~{v20},~{v21},~{v22},~{v23},~{v24},~{v25},~{v26},~{v27},~{v28},~{v29},~{v30},~{v31}"()
+  ret void
----------------
sfertile wrote:
> A couple minor suggestions
> 
> 1) Use only 2 or 3 callee saved vector registers as clobbers. It will show how we  allocate stack space to store all vector registers from N to 31 where N is the lowest used csr vr, and make the test a bit more concise. 
> 2) Have V12 as a clobber to show that it is not callee saved.
Ignore number 2. you already have that with v13, I should have paid more attention :(.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88676/new/

https://reviews.llvm.org/D88676