[PATCH] D88541: [AArch64] Don't merge sp decrement into later stores when using WinCFI

[Eli Friedman via Phabricator via llvm-commits]

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1869
+      return E;
+  }
+
----------------
mstorsjo wrote:
> efriedma wrote:
> > If we're using the same code to do this check in multiple places, should we factor it out?
> I can at least factor out the whole `needsWinCFI` part of it, but other than that, it feels a bit obscure to factor it out further, e.g with `if (shouldSkipMatchingUpdateBackwardsForwards(BaseReg, I->getMF()) return E;`, even if that allows factoring out some more checks and the code comment.
Okay, that's reasonable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88541/new/

https://reviews.llvm.org/D88541