[PATCH] D88617: [PDB] Use one func id DenseMap instead of per-source maps, NFC

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lld/COFF/DebugTypes.cpp:658
     }
-    if (ty.kind() == LF_FUNC_ID || ty.kind() == LF_MFUNC_ID) {
-      bool success = ty.length() >= 12;
----------------
aganea wrote:
> Before, we were calling this `if`, even for non-uniqued records, meaning that we were doing (potentially) too many insertions. Now this happens only for 'unique' records, do I understand that well?
Yes. Previously, each source had its own map, which needed to to contain all LF_FUNC_ID records even if they were not unique. Now, because we later merge together all the mappings from all the sources, we have one map that is a complete global mapping from func id to type for the final PDB.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88617/new/

https://reviews.llvm.org/D88617