[PATCH] D88617: [PDB] Use one func id DenseMap instead of per-source maps, NFC

[Alexandre Ganea via Phabricator via llvm-commits]

aganea accepted this revision.
aganea added a comment.
This revision is now accepted and ready to land.

Looks good, thanks!



================
Comment at: lld/COFF/DebugTypes.cpp:658
     }
-    if (ty.kind() == LF_FUNC_ID || ty.kind() == LF_MFUNC_ID) {
-      bool success = ty.length() >= 12;
----------------
Before, we were calling this `if`, even for non-uniqued records, meaning that we were doing (potentially) too many insertions. Now this happens only for 'unique' records, do I understand that well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88617/new/

https://reviews.llvm.org/D88617