[llvm] 674f578 - [gardening] Replace some uses of setDebugLoc(DebugLoc()) with dropLocation(), NFC

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 10:06:24 PDT 2020


Sorry for the breakage, thanks for reverting this.

vedant

> On Sep 30, 2020, at 1:54 AM, Jeremy Morse <jeremy.morse.llvm at gmail.com> wrote:
> 
> Hi,
> 
> On Wed, Sep 30, 2020 at 7:26 AM Petr Hosek via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> We're seeing a segfault when compiling compiler-rt builtins that seems to have been introduced by this change:
> 
> We're seeing this too, reverted in http://reviews.llvm.org/rG05659606a2af7
> 
> I had a look at the call site in FoldBranchToCommonDest, it looks like
> dropLocation is being called when the instruction is not yet inserted
> into a block or function, causing calls to getParent() to return null.
> 
> --
> Thanks,
> Jeremy



More information about the llvm-commits mailing list